Conversation
svenzik
force-pushed
the
WE2-967-allow-http
branch
from
June 9, 2025 07:23
a9ab5dd to
3d24ee2
Compare
mrts
approved these changes
Jun 13, 2025
mrts
requested changes
Nov 13, 2025
| if (StringUtils.endsWith(localOrigin, "/")) { | ||
| throw new IllegalArgumentException("Configuration parameter local-origin cannot end with '/': " + localOrigin); | ||
| } | ||
| if (StringUtils.startsWith(localOrigin, "http:")) { |
Member
There was a problem hiding this comment.
I feel uneasy about doing this so directly, folks may start copy-pasting this into their code without thinking.
Can we perhaps use a special profile enable-http and add thorough comments to make it absolutely clear that this should not be used in production? Or am I too paranoid, do we want to assume abusing the loopback address is impossible?
Member
There was a problem hiding this comment.
As discussed, a big warning comment is sufficient, no need for separate profile.
mrts
force-pushed
the
WE2-967-allow-http
branch
from
November 13, 2025 15:12
0f9d6ab to
8c34c66
Compare
WE2-967 Signed-off-by: Sven Mitt <svenzik@users.noreply.github.com>
svenzik
force-pushed
the
WE2-967-allow-http
branch
from
September 11, 2026 14:27
8c34c66 to
4acee57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WE2-967
Signed-off-by: Sven Mitt svenzik@users.noreply.github.com